Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch executor manager to ignore extra plugins discovered during CI tests #1870

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Patch executor manager to ignore extra plugins discovered during CI tests #1870

merged 2 commits into from
Nov 30, 2023
+18 −0

Conversation

araghukas
Copy link
Contributor

@araghukas araghukas commented Nov 30, 2023 •
edited
Loading

Quick fix for this error:

ModuleNotFoundError: No module named 'doc/source/how_to/execution/custom_executors/timing_plugin'

This happens during test_deploy_status() in the CI tests. The reason is that the "timing plugin" created in our how-to's is discovered by _executor_manager.

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@araghukas araghukas requested a review from a team as a code owner November 30, 2023 15:32
@araghukas
Copy link
Contributor Author

araghukas commented Nov 30, 2023 •
edited
Loading

NOTE: deliberately omitting changelog update for this one. Problem was discovered after merging #1868, but is strictly a CI tests issue so far as I can tell. Only changes are to a particular unit test (test_deploy_status).

Added in changelog under an "Operations" tag

Tests are passing apart from this. ✅

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Merging #1870 (c2904a6) into develop (6c9ce39) will increase coverage by 1.02%.
Report is 1 commits behind head on develop.
The diff coverage is 98.50%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1870      +/-   ##
===========================================
+ Coverage    83.81%   84.83%   +1.02%     
===========================================
  Files          293      180     -113     
  Lines        14371    11152    -3219     
  Branches       195        0     -195     
===========================================
- Hits         12045     9461    -2584     
+ Misses        2192     1691     -501     
+ Partials       134        0     -134
Flag Coverage Δ *Carryforward flag
Dispatcher 92.23% <98.50%> (+1.41%) ⬆️
Functional_Tests ?
SDK 79.09% <ø> (+0.05%) ⬆️ Carriedforward from 8c0b430
UI_Backend ?
UI_Frontend ?

*This pull request uses carry forward flags. Click here to find out more.

@kessler-frost kessler-frost enabled auto-merge (squash) November 30, 2023 15:45
@kessler-frost kessler-frost merged commit 75b8272 into develop Nov 30, 2023
14 checks passed
@kessler-frost kessler-frost deleted the amend_test_deploy_status branch November 30, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kessler-frost kessler-frost kessler-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@araghukas @kessler-frost